Fix: public suffixes tld parsing#110
Merged
Merged
Conversation
…lic suffixes file to avoid collisions with other jars
Member
|
Thanks. Released as webarchive-commons 2.0.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Heritrix dependency
crawler-commons-1.4contains a newer version of thepublicsuffix.orgTLD list:effective_tld_names.datin the root of their jar, which collides with ours, and our parser then fails while trying to parse the new version. This branch moves our copy of the file into a namespaced folder to reduce collisions, updates the logic to handle the encountered errors, adds testing for those cases, and updates to the current latest version of the public suffixes file.